Set IsTabStop=False on scroll buttons in TabView #7539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
approved these changes
Jul 29, 2022
llongley
approved these changes
Jul 29, 2022
|
🎉 Handy links: |
ranjeshj
added
area-TabView
team-Controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scroll Left/Right buttons in TabView are removed from the UIA tree. But they are still keyboard focusable. This gives a very bad experience when using Narrator. If you tab to these buttons, Narrator has no info about them and remains silent. This is very confusing.
It is not necessary for these buttons to be keyboard focusable. You can navigate and scroll through the tab list using the left and right arrows, so there is no reason to invoke these scroll buttons when using keyboard navigation.
Ideally, in addition to removing these buttons from the tab order, we would also add these buttons back to the UIA tree. This would enable them to be invoked by tools such as Voice Access. However, these buttons are inside the ListView template, and ListView has custom logic for creating its UIA children - it only shows the listview items, so other general UI under the ListView template does not show up. Hence these buttons do not appear even if they are not in the 'Raw' tree. The tab strip is still navigable with Voice Access using the "press right" and "press left" commands, even if it is not ideal.